No significant bundle size changes to report.

Generated by 🚫 dangerJS

• Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

AsyncMode -> ConcurrentMode ->createRoot -> ？
When will it be stable

@Go7hic When it's stable, you will see it in release notes. :-) We can't predict the future, but we're working to ship it. There's still more work ahead.

Deprecate javascript: URLs as a common attack surface.

Is there something I can call to make javascript: urls an error, not a warning? Or does the feature flag require a special build of React to enable this?

EDIT: AFAICT not really — in react tests there’s:

const ReactFeatureFlags = require('shared/ReactFeatureFlags');
ReactFeatureFlags.disableJavaScriptURLs = true;

but i don’t think it will work in actual react builds.

I would be highly in favor of adding a function like import { disableJavascriptUrls } from react for this. Given how common and easy it is to have a huge XSS hole in links, I don’t think it’s appropriate to wait until React 17 when the feature is already there. A function with a recommendation to use it in the CHANGELOG (but still opt-in to preserve semver) seems like the best choice.

You can always do custom builds of React from master. (Even from the same commits that go out in a release.) And toggle it on. That's what we do. We generally don't allow runtime configuration because it doesn't compose well. Like if you have several apps on one page.

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

We've added initial infrastructure but haven't started on the implementation yet. Please let's keep this thread focused on the 16.9 release.

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

• Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

Don't forget who was the first mentioning this issue for core team, lol

https://twitter.com/6graNik/status/1060898694092988421

Good Job

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

@Andarist this is a great usecase for async act. made a PR with a fix and some notes - final-form/react-final-form#578

Is there anything significant new feature I should learn for this release? (Like hooks / suspense on previous releases)?

There will be a blog post, but this release is relatively minor in terms of new features.

@gaearon: Did we intentionally omit mention of unstable_createSyncRoot ?