Update 2016-11-16-react-v15.4.0.md #8339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edge and IE11 both show user marks and measures in the Dev Tools, so it's technically not accurate to say that only Chrome has this feature.
aweary
suggested changes
Nov 18, 2016
| @@ -41,7 +41,7 @@ To use it: | |||
|
|
|||
| Note that the numbers are relative so components will render faster in production. Still, this should help you realize when unrelated UI gets updated by mistake, and how deep and how often your UI updates occur. | |||
|
|
|||
| Currently Chrome is the only browser supporting this feature, but we use the standard [User Timing API](https://developer.mozilla.org/en-US/docs/Web/API/User_Timing_API) so we expect more browsers to add support for it. | |||
| Currently Chrome, Edge, and IE are the only browsers supporting this feature, but we use the standard [User Timing API](https://developer.mozilla.org/en-US/docs/Web/API/User_Timing_API) so we expect more browsers to add support for it. | |||
There was a problem hiding this comment.
Can we specify that this is IE11, since IE9 and IE10 are still supported by React.
There was a problem hiding this comment.
The feature itself (user timings) has been in there since IE10, and Firefox supports it too (caniuse). However I'm not sure if IE10 DevTools actually surfaces it; I'd have to grab a Windows VM and test.
My understanding was that the point here was to indicate which browsers support surfacing the user timing info to Dev Tools, since otherwise we should mention Firefox too for completeness.
|
I think it's fine, "currently" sorta implies recent versions. Thank you so much, I had no idea! |
gaearon
added
Documentation: needs merge to stable
and removed
GH Review: review-needed
labels
gaearon
added a commit
that referenced
this pull request
Nov 18, 2016
Update 2016-11-16-react-v15.4.0.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge and IE11 both show user marks and measures in the Dev Tools, so it's technically not accurate to say that only Chrome has this feature.
Here's what this looks like in Edge:
BTW thank you for聽promoting
performance.mark()andperformance.measure(). 馃槂 Surfacing this info into the Dev Tools makes webdevs much more likely to use these APIs, and they're incredibly useful for telemetry, performance analyses, etc. It's great to see React leading on this.